Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_backend: Switch from protobuf 2 to prost 0.11 #691

Merged
merged 2 commits into from
Nov 3, 2022
Merged

zcash_client_backend: Switch from protobuf 2 to prost 0.11 #691

merged 2 commits into from
Nov 3, 2022

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Nov 2, 2022

The latter is maintained by the Tokio developers, and has easy integration with the tonic gRPC library which is actively maintained.

@codecov
Copy link

codecov bot commented Nov 2, 2022 •
edited
Loading

Codecov Report

Base: 73.64% // Head: 73.67% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (68e2149) compared to base (df1cbbd).
Patch coverage: 27.27% of modified lines in pull request are covered.

❗ Current head 68e2149 differs from pull request most recent head 587e1fa. Consider uploading reports for the commit 587e1fa to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
+ Coverage   73.64%   73.67%   +0.03%     
==========================================
  Files         104      104              
  Lines       10157    10155       -2     
==========================================
+ Hits         7480     7482       +2     
+ Misses       2677     2673       -4
Impacted Files Coverage Δ
zcash_client_backend/src/data_api/error.rs 16.66% <0.00%> (ø)
zcash_client_backend/src/welding_rig.rs 97.36% <ø> (ø)
zcash_client_sqlite/src/chain.rs 20.77% <20.00%> (ø)
zcash_client_backend/src/proto.rs 80.00% <40.00%> (+4.32%) ⬆️
zcash_primitives/src/sapling/redjubjub.rs 90.32% <0.00%> (-1.08%) ⬇️
zcash_client_backend/src/scan.rs 41.66% <0.00%> (+1.19%) ⬆️
zcash_history/src/entry.rs 29.16% <0.00%> (+2.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@str4d
zcash_client_backend: Switch from protobuf 2 to prost 0.11
379b703 
The latter is maintained by the Tokio developers, and has easy
integration with the `tonic` gRPC library which is actively maintained.
@str4d str4d mentioned this pull request Nov 2, 2022
Merged
nuttycom
nuttycom approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo Clippy complaints.

@str4d str4d merged commit cfc8088 into main Nov 3, 2022
@str4d str4d mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @nuttycom